Closed
Conversation
szaimen
added
enhancement
design
szaimen
requested review from
GretaD,
Pytal,
artonge,
julien-nc,
marcoambrosini and
skjnldsv
Contributor
Author
|
/backport to stable22 |
Contributor
Author
|
/backport to stable21 |
Contributor
Author
|
/backport to stable20 |
szaimen
changed the title
Contributor
Author
|
/compile amend / |
marcoambrosini
approved these changes
Jul 26, 2021
kesselb
approved these changes
Jul 26, 2021
Contributor
Author
|
/compile amend / |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
enh/noid/usermanagement/add-icon-to-user-groups
branch
from
2cb3a84 to
4130984
Compare
artonge
reviewed
Jul 26, 2021
Comment on lines
84
to
85
| :to="{ name: 'group', params: { selectedGroup: encodeURIComponent(group.id) } }"> | ||
| :to="{ name: 'group', params: { selectedGroup: encodeURIComponent(group.id) } }" | ||
| icon="icon-group"> |
Contributor
There was a problem hiding this comment.
Too many icons kill the icons, no ? But the AppNavigationCaption could use one.
Contributor
There was a problem hiding this comment.
Confused by the state changes, Am I a bit late to the party ?
Contributor
Author
There was a problem hiding this comment.
I disaggree on this one. Having no icons here looks pretty bad thats why I've added them here:
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Let's summon @nextcloud/designers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: szaimen szaimen@e.mail.de