Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
This comment has been minimized.
This comment has been minimized.
5 tasks
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Member
Author
|
NODB failure is unrelated 🎉 |
Contributor
|
Did you push the production or dev js? |
Member
Author
Contributor
Member
Author
Yes, always have been 🔫 😉 server/.github/workflows/node.yml Lines 44 to 52 in 717636f |
Contributor
|
okay and shouldn't we wait until the tests finish? |
Member
Author
Finished! 🛎️ 😁 |
szaimen
approved these changes
Jul 22, 2021
artonge
previously requested changes
Jul 22, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Yet another shot at it.
Lots of outdated sections 😩
I didn't change the babel config as this is causing export issues and make everything not defined:
dav is not definedOC is not definedetc etc. Most likely an issue with umd/commonjs exportsFollowups:
vue/no-mutating-propsserver/.eslintrc.js
Line 18 in 7ca81f3