Allow to get a local cloud id without going through the contacts manager#27884
Merged
Allow to get a local cloud id without going through the contacts manager#27884
Conversation
skjnldsv
approved these changes
Jul 9, 2021
Member
|
Should we do a generic short cut in the getCloudId() for the local server? |
a9b75bf to
69bd61e
Compare
Member
Author
|
@nickvergessen I added a shortcut as the id is also just constructed like this in the CloudIdManager, but having the possibility to request a local cloud id still makes sense for the manager I'd say, so I kept that. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
52c692a to
acba487
Compare
blizzz
reviewed
Jul 14, 2021
Signed-off-by: Julius Härtl <jus@bitgrid.net>
acba487 to
7179002
Compare
blizzz
approved these changes
Jul 14, 2021
Member
Author
|
/backport f43c2b4 to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As from nextcloud/activity#617, getCloudId can be expensive, especially on large instances since curently the contacts manager is called to search for the cloud id which may lead to slow queries as it searches the oc_card_properties table with a LIKE with wildcards on every file action:
For local users this PR allows to omit the remote parameter when getting the cloud id for a local user. The display name will then be fetched from the user manager instead and the remote URL will be constructed as it was done before in the User class.