[stable21] avoid fread on directories and unencrypted files#27406
Merged
[stable21] avoid fread on directories and unencrypted files#27406
Conversation
backportbot-nextcloud
bot
requested review from
danxuliu,
icewind1991,
jknockaert,
juliusknorr,
kesselb,
rullzer,
schiessle and
vitormattos
Contributor
|
Still an issue on NC 21.0.3 can we add it on the next release ? @icewind1991 @rullzer @acsfer |
AndyXheli
approved these changes
Jul 2, 2021
icewind1991
approved these changes
Jul 27, 2021
Member
|
/rebase |
github-actions
bot
force-pushed
the
backport/24966/stable21
branch
from
694b808 to
c290551
Compare
AndyXheli
approved these changes
Aug 14, 2021
Member
|
CI says no |
This comment has been minimized.
This comment has been minimized.
Contributor
|
No |
This comment has been minimized.
This comment has been minimized.
Contributor
|
@skjnldsv anyone else that can look at this code since the original creator no longer wants to work on this? |
Member
|
/rebase |
added 7 commits
September 3, 2021 13:40
Reworking the logic in order to first check the filecache and only then reading the fileheader. This in order to solve #21578.
Signed-off-by: Jasper Knockaert jasper@knockaert.nl
nextcloud-command
force-pushed
the
backport/24966/stable21
branch
from
c290551 to
bb092dd
Compare
Member
|
Drone failure is unrelated. Not sure why Psalm is unhappy here while it was happy on 22 (master that time): EDIT: Psalm failure related to #28700, which requires hence backport first. |
skjnldsv
approved these changes
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #24966