Merged
Conversation
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ChristophWurst,
MorrisJobke,
blizzz and
skjnldsv
MorrisJobke
reviewed
May 25, 2021
core/Command/User/Report.php
Outdated
| 'count-dirs', | ||
| null, | ||
| InputOption::VALUE_NONE, | ||
| 'Also count the number of user directories in the database (could time out on huge installations, there for defaults to no with 500+ users)' |
Member
There was a problem hiding this comment.
Suggested change
| 'Also count the number of user directories in the database (could time out on huge installations, there for defaults to no with 500+ users)' | |
| 'Also count the number of user directories in the database (could time out on huge installations, therefore defaults to no with 500+ users)' |
blizzz
approved these changes
May 25, 2021
core/Command/User/Report.php
Outdated
| $rows[] = [' ']; | ||
| $rows[] = ['user directories', $userDirectoryCount]; | ||
|
|
||
| if ($total <= 500 || $input->getOption('count-dirs')) { |
MorrisJobke
approved these changes
May 25, 2021
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
CS not happy, but code looks good 👍
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/make-user-report-scale
branch
from
0e3b20b to
f9b407d
Compare
Member
|
@nickvergessen Backport down to 20? |
Member
Author
|
I guess it's fine |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]