do not use private AccountManager in UsersController#27035
Merged
Conversation
Merged
blizzz
force-pushed
the
techdebt/26866/userscontroller-accountmanager-api
branch
3 times, most recently
from
fd45828 to
dd1f793
Compare
blizzz
added
3. to review
blizzz
requested review from
ChristophWurst,
PVince81,
danxuliu,
juliusknorr,
nickvergessen and
skjnldsv
blizzz
force-pushed
the
techdebt/26866/userscontroller-accountmanager-api
branch
from
dd1f793 to
f3989b8
Compare
PVince81
approved these changes
May 25, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 looks fine
please consider my minor comment about in_array
juliusknorr
approved these changes
May 25, 2021
blizzz
force-pushed
the
techdebt/26866/userscontroller-accountmanager-api
branch
from
f3989b8 to
847ed37
Compare
- extends IAccountProperty for verificationData getters and setters - implementation thereof ^ - and of course adaption of UsersController Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contributes to #26866