Port dav calendar settings page to Vue.js

[francoisfreitag]

• Drop reliance on deprecated global jQuery object.
• Allow testing user interactions.
• Use newer technology stack.

---

Add infrastructure to test Vue components:

• Use recommended libraries:

  • https://vuejs.org/v2/guide/testing.html#Recommendations
  • Use jest-dom for robust assertions on the DOM state
  • Use user-event to be more representative of user actions

• Code is transpiled by Jest, with the help of vue-jest.

[artonge]

Nice @francoisfreitag,

Could you add some before/after screenshots ?

| Before | After |
|:---------:|:------:|
|xxxxxxx|xxxxx|

How do translations get collected? IIUC, this should be automatic?

This is done by the community, so you don't have to think about it.

[francoisfreitag]

Thanks for the reviews!

Before	After

Changes

• Use initialStateProvider API
• Use @nextcloud/axios for the requests
• From Rewrite requesttoken.spec.js with Jest #27286:
  • use common babel config for tests
  • unify test framework to Jest

Pulled relevant bits in separate commits, will eventually squash all commits.

---

I believe all feedback has been addressed and this PR is ready for another round of reviews.

[francoisfreitag]

Changes

• Squash commits
• Use InitialState instead of deprecated OCP\IInitialStateService

[artonge]

LGTM

[tcitworld]

Apart from the js config global changes, LGTM

[francoisfreitag]

Changes

• Add missing enable of birthday calendar checkbox in tests.

[francoisfreitag]

Apart from the js config global changes, LGTM

Can you precise your expectation here?

Are you asking to rewrite the existing JS so that it can be bundled as CommonJS modules? (#27022 and #23973)

[francoisfreitag]

Changes

diff --git a/apps/dav/src/views/CalDavSettings.spec.js b/apps/dav/src/views/CalDavSettings.spec.js
index 6f25106bd6..3f9254a301 100644
--- a/apps/dav/src/views/CalDavSettings.spec.js
+++ b/apps/dav/src/views/CalDavSettings.spec.js
@@ -92,6 +92,7 @@ describe('CalDavSettings', () => {
                        return Promise.resolve()
                })
                await userEvent.click(generateBirthdayCalendar)
+               expect(generateBirthdayCalendar).toBeEnabled()

                OCP.AppConfig.setValue.mockClear()
                await userEvent.click(sendEventReminders)

[skjnldsv]

Can you precise your expectation here?

I think he meant the js files changed outside of /dav/. But it's because of the babel config update. All good

[francoisfreitag]

Awesome, thanks for the reviews and integrating!