[stable21] Fix empty password check for mail shares#26625
Merged
MorrisJobke merged 1 commit intostable21from Apr 20, 2021
Merged
[stable21] Fix empty password check for mail shares#26625MorrisJobke merged 1 commit intostable21from
MorrisJobke merged 1 commit intostable21from
Conversation
PVince81
requested review from
ChristophWurst,
LukasReschke,
MorrisJobke,
juliusknorr and
skjnldsv
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/noid/fix-sharemail-empty-password-check
branch
from
823b110 to
fe0f1c7
Compare
PVince81
changed the title
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
rullzer
approved these changes
Apr 19, 2021
|
The backport to stable19 failed. Please do this backport manually. |
Member
Author
|
stable19 here #26646 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #24364 (backport only some piece of it that fixes a bug)
While the above PR refactors link and mail shares, I tried to keep the fix to the minimum and isolate the matching bit to the mail share code.
See https://github.com/nextcloud/server/pull/24364/files#diff-6c825986578290fe355bffe05c5232629a36e554d48f5d889bb2c1ec73645265R994 for the approach.