Add proper PHPDoc tags to files ApiController#26410
Merged
MorrisJobke merged 2 commits intomasterfrom May 27, 2021
Merged
Conversation
rullzer
approved these changes
Apr 8, 2021
Member
|
Psalm is not happy |
Contributor
|
server/lib/private/User/Session.php Lines 227 to 229 in f99f463 |
Merged
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
force-pushed
the
fix/noid/phpdoc
branch
from
e0f373a to
bcf01a1
Compare
Member
Author
|
Rebased - maybe Psalm is happy. |
MorrisJobke
requested review from
ChristophWurst,
LukasReschke,
PVince81 and
juliusknorr
Member
Author
|
CI failure is unrelated |
Member
|
This broke tests on master :( |
LukasReschke
added a commit
that referenced
this pull request
May 28, 2021
Regression by #26410 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Merged
LukasReschke
added a commit
that referenced
this pull request
May 28, 2021
Regression by #26410 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should make Psalm a bit more happy (because it does not need to infer it)