Skip to content

Comments

Bump @nextcloud/vue from 3.2.0 to 3.7.2#26057

Merged
dependabot-preview[bot] merged 3 commits intomasterfrom
dependabot/npm_and_yarn/nextcloud/vue-3.7.2
Mar 11, 2021
Merged

Bump @nextcloud/vue from 3.2.0 to 3.7.2#26057
dependabot-preview[bot] merged 3 commits intomasterfrom
dependabot/npm_and_yarn/nextcloud/vue-3.7.2

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Mar 11, 2021 •
edited
Loading

Bumps @nextcloud/vue from 3.2.0 to 3.7.2.

Release notes

Sourced from @nextcloud/vue's releases.

v3.7.2

v3.7.2 (2021-03-10)

Full Changelog

Fixed bugs:

  • Render the first action icon slot if single action #1753 (skjnldsv)
  • Fix formattedOptions var in multiselect docs #1744 (skjnldsv)

v3.7.1

Added

Changed

v3.7.0

v3.7.0 (2021-03-03)

Added

Changed

v3.6.0

v3.6.0 (2021-02-25)

Added

Changed

... (truncated)

Changelog

Sourced from @nextcloud/vue's changelog.

v3.7.2 (2021-03-10)

Full Changelog

Fixed bugs:

  • Render the first action icon slot if single action #1753 (skjnldsv)
  • Fix formattedOptions var in multiselect docs #1744 (skjnldsv)

v3.7.1 (2021-03-10)

Added

Changed

v3.7.0 (2021-03-03)

Added

Changed

v3.6.0 (2021-02-25)

Added

Changed

... (truncated)

Commits
  • d318aa9 3.7.2
  • 014d4d1 v3.7.2 changelog
  • 7ca94fc Merge pull request #1744 from nextcloud/fix/docs-multiselect
  • f8026bd Merge pull request #1753 from nextcloud/fix/actions-single-icon-slot
  • e4fdf7d 3.7.1
  • eed2bad V3.7.1
  • c950c2a Merge pull request #1754 from nextcloud/dependabot/npm_and_yarn/debounce-1.2.1
  • 40a8eb7 Bump debounce from 1.2.0 to 1.2.1
  • 1dcc668 Render the first action icon slot if single action
  • 4649822 Merge pull request #1718 from nextcloud/fix/multiselect_tag
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @ma12-co.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added this to the Nextcloud 22 milestone Mar 11, 2021
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 11, 2021
Closed
@skjnldsv skjnldsv requested a review from ChristophWurst March 11, 2021 07:53
@skjnldsv

This comment has been minimized.

Sign in to view
@dependabot-preview

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@dependabot-preview

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv requested a review from PVince81 March 11, 2021 09:04
@skjnldsv

This comment has been minimized.

Sign in to view
@PVince81

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@PVince81
Copy link
Member

PVince81 commented Mar 11, 2021

MultiSelects will need adjusting

Wow, we're so late behind? thinking

can you adjust the affected locations as you're the most familiar with this change ?

@skjnldsv
Copy link
Member

skjnldsv commented Mar 11, 2021

can you adjust the affected locations as you're the most familiar with this change ?

Incoming

skjnldsv
skjnldsv requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked

skjnldsv
skjnldsv approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

dependabot-preview bot and others added 2 commits March 11, 2021 12:14
@dependabot-preview @skjnldsv
Bump @nextcloud/vue from 3.2.0 to 3.7.2
12a1d4a 
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 3.2.0 to 3.7.2.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v3.2.0...v3.7.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@skjnldsv
Compile js
7f06a0c 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the dependabot/npm_and_yarn/nextcloud/vue-3.7.2 branch from 2087460 to 079b110 Compare March 11, 2021 11:17
@skjnldsv
Fix SharingInput Multiselect
31ddfb0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the dependabot/npm_and_yarn/nextcloud/vue-3.7.2 branch from 079b110 to 31ddfb0 Compare March 11, 2021 11:30
@skjnldsv skjnldsv mentioned this pull request Mar 11, 2021
Closed
@PVince81
Copy link
Member

PVince81 commented Mar 11, 2021 •
edited
Loading

I did some quick testing with sharing and it looked fine.

However I found this issue with comments that doesn't exist on master: just try typing and observe the logs, and it's not possible to post:
image

  • BUG: REGRESSION: comments not working any more

@PVince81
Copy link
Member

PVince81 commented Mar 11, 2021 •
edited
Loading

  • avatar menu works but icon misalignment (minor, could be fixed separately)

on this PR:
image

on master:
image

@dependabot-preview dependabot-preview bot merged commit 69c4578 into master Mar 11, 2021
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/nextcloud/vue-3.7.2 branch March 11, 2021 14:11
@PVince81
Copy link
Member

PVince81 commented Mar 11, 2021

okay, so the bot merged it automatically... let's raise tickets for the remaining issues then

@PVince81
Copy link
Member

PVince81 commented Mar 11, 2021

I'll quickly look into the comment one and push a PR instead of a ticket

can someone look into avatar alignment ?

@PVince81 PVince81 mentioned this pull request Mar 11, 2021
Merged
@PVince81
Copy link
Member

PVince81 commented Mar 11, 2021

comments fix here: #26068

@rullzer
Copy link
Member

rullzer commented Mar 12, 2021

can someone look into avatar alignment ?

@PVince81 can you createa an issue?

@PVince81
Copy link
Member

PVince81 commented Mar 12, 2021

can someone look into avatar alignment ?

@PVince81 can you createa an issue?

avatar alignment issue raised here: nextcloud-libraries/nextcloud-vue#1762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: dependencies javascript

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @PVince81 @rullzer @marcoambrosini