Update acceptance tests dependencies#25983
Merged
Conversation
danxuliu
force-pushed
the
update-acceptance-tests-dependencies
branch
from
6a1cd15 to
c709152
Compare
Member
Author
|
I have rebased to fix (and document in the commit message, so that is why I did not use a fixup commit) a couple of acceptance test failures that only happened with the Docker container used in CI. |
Member
Author
|
I have run the failing test several times locally and it always passed, so it should be just a hiccup in CI. |
Member
|
#25975 merged |
Member
|
acceptance-access-levels fails |
The PHPUnit update also required an update of "symfony/yaml", so besides the changes needed for PHPUnit the "behat.yml" file also had to be adjusted. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since version 1.4.0 the Selenium driver for Mink uses again the element on which the value was set (see minkphp/MinkSelenium2Driver#286). When creating a new folder or renaming one sending a new line ("\r") caused the element on which the value was set to be removed, so the element was no longer attached to the DOM when the driver tried to use it again, and thus a "StaleElementReference" exception was thrown. Due to this now it is needed to explicitly click the confirm button when creating a new folder. In the case of the renaming, on the other hand, nothing else besides not sending the new line is needed, as the Selenium driver now unfocuses the element (that is why it uses again the element after setting the value) which triggers the renaming. Besides that, the Selenium driver for Mink uses a library to simulate certain events, bitovi/syn. In version 1.4.0 that library was updated to version 0.0.3, which seems to somehow break pressing the "escape" key. Due to this now the sharing menu has to be closed by pressing "enter" on the share menu button instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since version 1.8.0 of Mink "Mink::getSession()" no longer starts the session automatically (see minkphp/Mink#705), so it now needs to be explicitly started. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
skjnldsv
force-pushed
the
update-acceptance-tests-dependencies
branch
from
c709152 to
f216b93
Compare
skjnldsv
approved these changes
Mar 30, 2021
Member
|
Good to go, the acceptance acceptance-app-files-sharing failure is on master as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be rebased on master once #25975 is merged (it is set as draft to prevent that, but it is ready for review nevertheless).
This pull request updates the acceptance tests dependencies, which requires some syntax changes (mostly
PHPUnit_Framework_AsserttoAssert). Due to that, and to ease future backports I would suggest to backport it (so please do not merge before the backports of #25975 are also merged to ensure that backportbot can do its magic :-) ). In any case if the backport fails feel free to ignore it ;-)