Filter out tables that does not belong to Nextcloud#25882
Merged
Conversation
Contributor
@kesselb What does this in detail mean? Historically it was possible to use a custom database table prefix. I've e.g. set " |
Contributor
Author
|
@j-ed updated the pr title ;) Nextcloud 21 the function to read all tables from a database returns all tables in a database. After this patch Nextcloud 21 also filters the database tables like Nextcloud 20. |
fc6b5a2 to
ad001f0
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
ad001f0 to
bc91eb7
Compare
nickvergessen
approved these changes
Mar 3, 2021
Contributor
Author
|
/backport to stable21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #25748
Some people run into
Unknown database type enum requested, Doctrine\\DBAL\\Platforms\\MariaDb1027Platform may not support it.on upgrade to 21. Yet we are not using enums in Nextcloud. But phpmyadmin does and some have tables by phpMyAdmin in their Nextcloud database.Turns out our filter for the database tables does not work.
How to test:
testtestin your Nextcloud databaselib/private/DB/Migrator.createSchema