send share notification instead of erroring on duplicate share

[icewind1991]

when creating a share that already exists, instead of erroring, resend the notifications

Signed-off-by: Robin Appelman robin@icewind.nl

[nickvergessen]

Need to test and confirm this doesn't break Talks reposting behaviour

[nickvergessen]

Seems to work

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2076: failure

checkers

• I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you

integration-ratelimiting

• failure block could not be found - most likely this run got canceled

Show full log

+ bash tests/drone-run-integration-tests.sh || exit 0
=========================
= List of changed files =
=========================
lib/composer/composer/autoload_classmap.php
lib/composer/composer/autoload_static.php
lib/private/Share20/Manager.php
lib/public/Share/Exceptions/AlreadySharedException.php
=========================
PHP files are modified
+ ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
Nextcloud was successfully installed
+ ./occ config:system:set redis host --value=cache
System config value redis => host set to string cache
+ ./occ config:system:set redis port --value=6379 --type=integer
System config value redis => port set to integer 6379
+ ./occ config:system:set redis timeout --value=0 --type=integer
System config value redis => timeout set to integer 0
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.local
System config value memcache.local set to string \OC\Memcache\Redis
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.distributed
PHP Warning:  Redis::connect(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /drone/src/lib/private/RedisFactory.php on line 92
An unhandled exception has been thrown:
RedisException: Redis server went away in /drone/src/lib/private/Memcache/Redis.php:55
Stack trace:
#0 /drone/src/lib/private/Memcache/Redis.php(55): Redis->get('4ce41d68edfec2e...')
#1 /drone/src/lib/private/App/InfoParser.php(60): OC\Memcache\Redis->get('/drone/src/apps...')
#2 /drone/src/lib/private/App/AppManager.php(511): OC\App\InfoParser->parse('/drone/src/apps...')
#3 /drone/src/lib/private/legacy/OC_App.php(589): OC\App\AppManager->getAppInfo('files', false, NULL)
#4 /drone/src/lib/private/AppFramework/App.php(70): OC_App::getAppInfo('files')
#5 /drone/src/lib/private/legacy/OC_App.php(270): OC\AppFramework\App::buildAppNamespace('files')
#6 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(108): OC_App::registerAutoloading('files', '/drone/src/apps...')
#7 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(82): OC\AppFramework\Bootstrap\Coordinator->registerApps(Array)
#8 /drone/src/lib/base.php(634): OC\AppFramework\Bootstrap\Coordinator->runInitialRegistration()
#9 /drone/src/lib/base.php(1076): OC::init()
#10 /drone/src/console.php(49): require_once('/drone/src/lib/...')
#11 /drone/src/occ(11): require_once('/drone/src/cons...')

[rullzer]

Sure

[rullzer]

Ah you need the since annotation I guess

[MorrisJobke]

/backport to stable20

[MorrisJobke]

/backport to stable21

[skjnldsv]

@icewind1991 @nickvergessen @rullzer
Now we can add the same share an unlimited amount of times.
Having the api NOT throw on conflict seems like a bad idea to me. Please fix this for 22!