Update variables.scss - Fallback font before Noto Color Emoji#25418
Update variables.scss - Fallback font before Noto Color Emoji#25418skjnldsv merged 1 commit intonextcloud:masterfrom
Conversation
I would put sans-serif before Noto Color Emoji. If you have none of the previous fonts installed but Noto Color Emoji is, the interface looks very ugly because it uses Noto Color Emoji then. That's exactly the case on my linux distribution.
kaktuspalme
changed the title
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
I'd also favor sans serif, @jancborchardt what do you think?
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Yup, that should indeed be the right order @kaktuspalme – thank you so much! :)
|
/backport to stable21 |
|
@LukasReschke I assume the Psalm security analysis is unrelated for SCSS changes? :) |
|
A sign-off on the commit is missing for the Developer Certificate of Origin (DCO), but seems not needed for a small change. @schiessle? |
|
/compile amend/ |
|
CI is unhappy |
|
/compile amend / |
|
/rebase |
|
/backport to stable22 |
|
/backport to stable23 |
|
(Adding a +1 that I'd love to see this merged.) |
|
/rebase |
skjnldsv
added
4. to release
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable23 |
|
/backport to stable22 |
9 participants
I would put sans-serif before Noto Color Emoji. If you have none of the previous fonts installed but Noto Color Emoji is, the interface looks very ugly because it uses Noto Color Emoji then. That's exactly the case on my linux distribution. See screenshot.