fixed publishing of user properties to lookup-server

[abangtor]

Fix #25290

Fix of the bug in the lookup_server_connector module to publish public user information to the lookup-server.

There is a bug in the getUserAccountData method in the RetryJob.php of the lookup-server-connector module.
The properties are written into an one dimensional array $publicData:

server/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php

Line 197 in 7668c86

$publicData[$property->getName()] = $property->getValue();

Later on the array is read as it is a two dimensional array:

server/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php

Lines 203 to 214 in 7668c86

	$data['name'] = $publicData[IAccountManager::PROPERTY_DISPLAYNAME]['value'] ?? '';
	$data['email'] = $publicData[IAccountManager::PROPERTY_EMAIL]['value'] ?? '';
	$data['address'] = $publicData[IAccountManager::PROPERTY_ADDRESS]['value'] ?? '';
	$data['website'] = $publicData[IAccountManager::PROPERTY_WEBSITE]['value'] ?? '';
	$data['twitter'] = $publicData[IAccountManager::PROPERTY_TWITTER]['value'] ?? '';
	$data['phone'] = $publicData[IAccountManager::PROPERTY_PHONE]['value'] ?? '';
	$data['twitter_signature'] = $publicData[IAccountManager::PROPERTY_TWITTER]['signature'] ?? '';
	$data['website_signature'] = $publicData[IAccountManager::PROPERTY_WEBSITE]['signature'] ?? '';
	$data['verificationStatus'] = [
	IAccountManager::PROPERTY_WEBSITE => $publicData[IAccountManager::PROPERTY_WEBSITE]['verified'] ?? '',
	IAccountManager::PROPERTY_TWITTER => $publicData[IAccountManager::PROPERTY_TWITTER]['verified'] ?? '',
	];

This causes the values to be empty and no properties are send to the loopup-server.

[kesselb]

Thanks 👍 Please squash the commits together and we are good.

[nickvergessen]

The lookup server also seems to check a signature at least for Twitter and website?

[kesselb]

Mind to add how to get the signature? We talked briefly about the signature at #25290 and were lost ;)

[renaudlemaire]

Seems good to me.

[renaudlemaire]

Still not fixed in 2023.

[Trolli07]

Seems good to me too.

[Fleoxi]

Seems good to me too.

[kesselb]

Conflicts 😞

Sorry, I'm not familiar with lookup_server_connector and therefore cannot review it.

[skjnldsv]

@ArtificialOwl you're our expert in lookup server, could you have a look when time allows? :)

[sorbaugh]

Reopening to review. Anything here that still needs to be done @abangtor ? We would like to help you get this one in :)

[susnux]

Rebasing went wrong - nevertheless copied the PR to the repo: #51229