Apps folder is defacto in root folder and not above#25238
Merged
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
ChristophWurst,
blizzz,
kesselb,
nickvergessen and
rullzer
nickvergessen
approved these changes
Jan 20, 2021
rullzer
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is really needed one can configure it in the apps_path config value anyways, but would only work if there is no "apps/" present in the root with this code anyways.
Was just looking through the base.php to reduce complexity there.