Bump doctrine/dbal from 2.12.0 to 3.0.0#24948
Merged
ChristophWurst merged 4 commits intomasterfrom Jan 8, 2021
Merged
Conversation
Contributor
|
https://github.com/doctrine/dbal/releases/tag/3.0.0 That are many changes 😨 |
Member
Author
Yes. And it's landing at a very unfortunate time for us. They won't release the 2.x for php8, so we either upgrade to 3.x for 21 or we'll have loads of problems later on. |
20ab393 to
8c54700
Compare
This was referenced Jan 5, 2021
c0bbcc7 to
b1e988a
Compare
This comment has been minimized.
This comment has been minimized.
53c47b4 to
f1691c9
Compare
ChristophWurst
commented
Jan 7, 2021
ChristophWurst
commented
Jan 7, 2021
This comment has been minimized.
This comment has been minimized.
366e124 to
434bd66
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
…s not used anymore and triggers an exception See doctrine/dbal@138eb85#diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
434bd66 to
f0c6cfd
Compare
…un into docker pull rate limits Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This was referenced Jan 8, 2021
rullzer
approved these changes
Jan 8, 2021
Member
rullzer
left a comment
There was a problem hiding this comment.
Looks good!
Quick smoke test also looked good.
ChristophWurst
commented
Jan 8, 2021
Member
Author
ChristophWurst
left a comment
There was a problem hiding this comment.
👍 For Morris' parts
This was referenced Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for php8 compat.
Changed APIs
$qb->execute()->fetch()"lost" the second and third parameter that we never used$qb->execute()->fetchColumn()"lost" its argument ->fetchOneshould be used instead, our code never supplied anything but0as first arg so this is fine$db->prepare()->execute()gives you a result object or throws, it does not returnfalseanymore. We could still return false but that completely swallows the error.Vanished APIs (e.g. because the new adapter can't provide them)
$qb->execute()->bindParam()(not used anyway)$qb->execute()->bindValue()(not used anyway)$qb->execute()->columnCount()(not used anyway)$qb->execute()->errorCode()(not used anyway)$qb->execute()->errorInfo()(not used anyway)$qb->execute()->setFetchMode()(not used anyway)Todo
fetchAllDetails of the breaking changes: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed