Use the Symfony dispatcher correctly#24892
Merged
MorrisJobke merged 1 commit intomasterfrom Jan 7, 2021
Merged
Conversation
rullzer
approved these changes
Dec 30, 2020
This comment has been minimized.
This comment has been minimized.
3bdad27 to
d820c97
Compare
* Event object as first arg (otherwise there is a notice in the logs) * `dispatch` MUST return the event object Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
d820c97 to
85454ac
Compare
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 989: failureacceptance-users
Show full log |
MorrisJobke
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dispatchMUST return the event object