[stable20] LDAP: fix inGroup for memberUid type of group memberships#24716
Merged
[stable20] LDAP: fix inGroup for memberUid type of group memberships#24716
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
also added some additional comments and renamed some vars to make it intuitive whats in them Signed-off-by: Tobias Perschon <tobias@perschon.at>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- the type check is not necessary anymore for the return type of _groupMembers() Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
MorrisJobke,
blizzz,
juliusknorr,
rullzer and
tofuSCHNITZEL
tofuSCHNITZEL
approved these changes
Dec 15, 2020
Contributor
tofuSCHNITZEL
left a comment
tofuSCHNITZEL
left a comment
There was a problem hiding this comment.
since the original PR was based on stable 20 code this should be easy to merge
blizzz
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #24402