Specify the boundary element of the Actions menu#24694
Closed
nickvergessen wants to merge 1 commit intomasterfrom
Closed
Specify the boundary element of the Actions menu#24694nickvergessen wants to merge 1 commit intomasterfrom
nickvergessen wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 456: failuremysql8.0-php7.4Show full log |
marcoambrosini
approved these changes
Dec 18, 2020
Member
|
I have no Idea about te "data-v..." attributes being the same. I checked the values bound as keys to the elements in the v-for loop and they're different. @skjnldsv or @juliushaertl ideas? |
Member
|
sadly doesn't fix #23617 as I hoped. |
Member
All same scoped-elements get the same vue scope id. |
Member
|
sooooo next steps? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

So, while this fixes the scrolling issue in the sidebar. It seems totally broken for multiple link shares now.
After inspecting, I saw they get the same vue element id?
This is already the case in master, but maybe due to the missing boundary-element it didn't matter before. Now the first items opens with an offset and the second item opens just on top of all the things, instead of "bellow" the action three-dot
@skjnldsv @juliushaertl @ma12-co any idea?
Fix #23872