[stable20] Avoid dashboard crash when accessibility app is not installed

[julien-nc]

Getting the accessibility theme is not safe and makes the dashboard crash soon enough to display a blank page when accessibility app is not installed.

This is already solved in 21.

[rullzer]

/compile amend /

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 396: failure

integration-ldap-openldap-numerical-id-features

• failure block could not be found - most likely this run got canceled

Show full log

+ bash tests/drone-run-integration-tests.sh || exit 0
=========================
= List of changed files =
=========================
apps/dashboard/js/dashboard.js
apps/dashboard/js/dashboard.js.map
apps/dashboard/src/helpers/getBackgroundUrl.js
=========================
bash files are modified
+ ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
Nextcloud was successfully installed
+ ./occ config:system:set redis host --value=cache
System config value redis => host set to string cache
+ ./occ config:system:set redis port --value=6379 --type=integer
System config value redis => port set to integer 6379
+ ./occ config:system:set redis timeout --value=0 --type=integer
System config value redis => timeout set to integer 0
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.local
System config value memcache.local set to string \OC\Memcache\Redis
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.distributed
PHP Warning:  Redis::connect(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /drone/src/lib/private/RedisFactory.php on line 92
An unhandled exception has been thrown:
RedisException: Redis server went away in /drone/src/lib/private/Memcache/Redis.php:55
Stack trace:
#0 /drone/src/lib/private/Memcache/Redis.php(55): Redis->get('cc970cdc7444c77...')
#1 /drone/src/lib/private/App/InfoParser.php(58): OC\Memcache\Redis->get('/drone/src/apps...')
#2 /drone/src/lib/private/App/AppManager.php(511): OC\App\InfoParser->parse('/drone/src/apps...')
#3 /drone/src/lib/private/legacy/OC_App.php(581): OC\App\AppManager->getAppInfo('files', false, NULL)
#4 /drone/src/lib/private/AppFramework/App.php(69): OC_App::getAppInfo('files')
#5 /drone/src/lib/private/legacy/OC_App.php(264): OC\AppFramework\App::buildAppNamespace('files')
#6 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(100): OC_App::registerAutoloading('files', '/drone/src/apps...')
#7 /drone/src/lib/base.php(644): OC\AppFramework\Bootstrap\Coordinator->runRegistration()
#8 /drone/src/lib/base.php(1091): OC::init()
#9 /drone/src/console.php(49): require_once('/drone/src/lib/...')
#10 /drone/src/occ(11): require_once('/drone/src/cons...')

[danxuliu]

Tested and works 👍

For reference in master this was fixed in #24456 Maybe it would be better to use the same syntax in stable20 too to ease future backports... although this code does not look like something that will receive much backports in the future, but who knows :-P