Migrate LDAP's install.php to a repair step#24406
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 30, 2020
Merged
Conversation
ChristophWurst
added
enhancement
3. to review
Member
Author
🙄 |
ChristophWurst
force-pushed
the
enhancement/ldap-install-php-to-repair-step
branch
from
8ef4904 to
0a8ccd5
Compare
juliusknorr
approved these changes
Nov 27, 2020
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Tested and works with settings up a fresh instance and connecting ldap. Config values are properly set
blizzz
requested changes
Nov 27, 2020
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/ldap-install-php-to-repair-step
branch
from
0a8ccd5 to
334f394
Compare
blizzz
added
4. to release
Member
|
retriggered CI because there were some issues over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't test because I never reset my dev instance. So let's see if CI catches anything :)