Use proper methods for display name retrieval#24318
Merged
ChristophWurst merged 2 commits intomasterfrom Jun 17, 2021
Merged
Conversation
MorrisJobke
requested review from
ChristophWurst,
juliusknorr,
kesselb,
rullzer and
skjnldsv
skjnldsv
reviewed
Nov 24, 2020
skjnldsv
reviewed
Nov 24, 2020
skjnldsv
reviewed
Nov 24, 2020
skjnldsv
approved these changes
Nov 30, 2020
ChristophWurst
approved these changes
Nov 30, 2020
ChristophWurst
added
4. to release
Member
Author
|
CI says no ... let me remove the DI part again as it causes a lot of trouble at other places :/ |
MorrisJobke
added
2. developing
Member
|
tech dept and not fully one -> let's move to 22 |
Member
|
Kill or continue? |
Member
Author
🔥 but the code and not the PR ... let me rebase and 🙏 |
splitt3r
requested changes
Apr 1, 2021
MorrisJobke
added
3. to review
MorrisJobke
force-pushed
the
techdebt/noid/remove-oc_user-getDisplayName
branch
from
b6d0274 to
22ed863
Compare
Member
Author
|
Rebased. |
splitt3r
approved these changes
Apr 5, 2021
Contributor
|
PHPUnit is not happy |
Member
|
@MorrisJobke could you check the tests? |
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
techdebt/noid/remove-oc_user-getDisplayName
branch
from
22ed863 to
2690481
Compare
Member
Author
Let's see if the latest change fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.