Add focus-visible outline for checkboxes and radio buttons#24255
Add focus-visible outline for checkboxes and radio buttons#24255
Conversation
|
Yes please!! ❤️ |
|
seems we can't consistently add rounded borders to outlines: https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-outline-radius I don't want to make this a real border as it will mess up with the layout in many places |
nonono, definitely! It needs to stay as floating as default html is! :) |
|
I'm mostly worried about triggering additional work for every app developer related to checkboxes if we merge this. |
What extra work do you have in mind? |
|
I predict that it won't always look good depending how checkboxes are used in apps, so tweaks by app devs will be needed. |
bbc5b64 to
3b62bfe
Compare
|
since we're now at the beginning of 22 I think we could merge this. it should leave enough time for app developers to adjust in case this causes visual glitches |
3b62bfe to
fab5eb4
Compare
marcoambrosini
left a comment
There was a problem hiding this comment.
I think that the focus outline should be --color-main-text, at least that's what was decided for buttons.
To make keyboard navigation visible in forms. When clicking with the mouse it doesn't appear. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
fab5eb4 to
49eff09
Compare






To make keyboard navigation visible in forms.
When clicking with the mouse it doesn't appear (it's the magic of :focus-visible instead of :focus)
Ref https://www.w3.org/WAI/WCAG21/quickref/#focus-visible
This is how it looks like in this PR using the outline style and tabbing with the keyboard:
Without this it is almost impossible to find out what checkbox or radio button is currently focussed.
Tested with the settings pages and in the talk app.
@nextcloud/designers