Don't leave cursors open

[nickvergessen]

Signed-off-by: Joas Schilling coding@schilljs.com

[nickvergessen]

/backport to stable20

[rullzer]

Looks sane.
🚀

[kesselb]

Nice 👍

[icewind1991]

closing the cursor before a return makes no functional difference and only clutters the code, the cursor will be closed automatically when the result goes out of scope.

it only makes sense to manually close cursors if there is significant work being done in a function after the results are fetched

[MorrisJobke]

closing the cursor before a return makes no functional difference and only clutters the code, the cursor will be closed automatically when the result goes out of scope.

Was about to ask this as well. It looks really odd that we need to actively close the cursor there. Does this really fix the OCI cursor leak?

[nickvergessen]

Well at least the OC_DB methods leave cursors behind I don't know why and how, maybe because of the static-ness.

[nickvergessen]

And then I think it doesn't hurt and we should just make it a pattern in our code base. So when someone adds a second query or some code after your query they dont need to magically remember to add a closeCursor for the query above

[MorrisJobke]

Fine by me