only filter submounts for fileinfo on demand#23865
Closed
icewind1991 wants to merge 1 commit intomasterfrom
Closed
only filter submounts for fileinfo on demand#23865icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
this removes the need to always setup all the sub storages when getting a folder info Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
approved these changes
Nov 3, 2020
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense, but those negations combined with multiple && and || doesn't make it easy to read 🙈
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34964: failureacceptance-app-files-sharing-link
Show full log |
Member
|
Is this still needed? |
Merged
Member
I guess not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this removes the need to always setup all the sub storages when getting a folder info
Signed-off-by: Robin Appelman robin@icewind.nl