[stable20] LDAP: when nesting is not enabled, the group filter can be applied right away#23570
Merged
[stable20] LDAP: when nesting is not enabled, the group filter can be applied right away#23570
Conversation
- helps performance, but skipping unnecessary entries
- reduces reoccuring info-level log output against groups that do not
qualify ("no or empty name")
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
MorrisJobke,
blizzz,
rullzer,
skjnldsv and
tofuSCHNITZEL
skjnldsv
approved these changes
Oct 19, 2020
Member
|
@blizzz Let's move this to 20.0.2 as we already released the RC1 of 20.0.1. Okay? |
blizzz
approved these changes
Oct 21, 2020
Member
🙈 |
Member
🤭 |
Member
|
Let's do it in 20.0.1 and next time I will just review with a -1 to properly block it in the UI. |
Member
|
Yeah, good thing to do in general. I simply oversaw your comment, and didn't think about it either. Yesterday was a messy day. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #23566