allow authenticating using urlencoded passwords#22992
Merged
MorrisJobke merged 2 commits intomasterfrom Jan 8, 2021
Merged
Conversation
juliusknorr
approved these changes
Oct 8, 2020
this allows authenticating with passwords that contain non ascii-characters in contexts that otherwise do not allow it (http basic) Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
force-pushed
the
password-urlencode
branch
from
53ddf39 to
c374bbf
Compare
MorrisJobke
reviewed
Jan 7, 2021
|
|
||
| foreach ($this->backends as $backend) { | ||
| if ($backend->implementsActions(Backend::CHECK_PASSWORD)) { | ||
| $uid = $backend->checkPassword($loginName, $password); |
Member
There was a problem hiding this comment.
Psalm says:
lib/private/User/Manager.php:241:22:error - UndefinedInterfaceMethod: Method OCP\UserInterface::checkPassword does not exist
Member
There was a problem hiding this comment.
But this is just the same as above. We don't properly export it. But it is there...
Member
There was a problem hiding this comment.
So we should probably just update the baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows authenticating with passwords that contain non ascii-characters in contexts that otherwise do not allow it (http basic)
Signed-off-by: Robin Appelman robin@icewind.nl