Conversation
Currently outgoing federated shares need to be enabled to allow WebDAV access to public shares. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 33063: failuremariadb10.4-php7.3Show full log |
skjnldsv
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until #20132 is fixed* the checkbox should explicitly mention its unexpected side effect.
*Note that the steps to reproduce mention using the viewer; the viewer case was fixed in nextcloud/viewer#581, but the issue of not being able to access public shares using WebDAV when outgoing federated shares are disabled is still valid
The wording of the option is just a suggestion; feel free to improve it :-)
When/If this is merged the user manual should be updated to reflect the new text in the settings.
Should this be backported to stable19 and stable18?