[stable18] Fix clicks on actions menu of non opaque file rows in acceptance tests#22504
Merged
juliusknorr merged 1 commit intostable18from Aug 31, 2020
Merged
[stable18] Fix clicks on actions menu of non opaque file rows in acceptance tests#22504juliusknorr merged 1 commit intostable18from
juliusknorr merged 1 commit intostable18from
Conversation
backportbot-nextcloud
bot
requested review from
ChristophWurst,
danxuliu,
juliusknorr,
rullzer and
skjnldsv
Member
@danxuliu Mind to have another look here? |
When a row is added to the file list the opacity of the file row is animated from transparent to fully opaque. As the file actions menu is a descendant of the row but overflows it when the row is not fully opaque clicks on the menu entries "fall-through" and are received instead by the rows behind. The opacity animation is a CSS animation, and it is not possible to know if a row is appearing or not except from its opacity (the row will have the "appear" CSS class even after the animation ended). Therefore it should be waited until the row of the file is fully opaque before using the menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/22481/stable18
branch
from
1a9f60f to
6d191c2
Compare
Member
|
Conflict fixed, but let's see what Drone says ;-) |
danxuliu
approved these changes
Aug 31, 2020
skjnldsv
approved these changes
Aug 31, 2020
juliusknorr
approved these changes
Aug 31, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #22481