Conversation
skjnldsv
added
3. to review
juliusknorr
reviewed
Aug 25, 2020
skjnldsv
force-pushed
the
fix/settings-chunks
branch
from
3a36db1 to
d6d2c6b
Compare
skjnldsv
force-pushed
the
fix/settings-chunks
branch
from
d6d2c6b to
c16ef0f
Compare
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
juliusknorr
approved these changes
Aug 31, 2020
MorrisJobke
added
4. to release
Member
|
@skjnldsv Mind to rebase and recreate? |
skjnldsv
force-pushed
the
fix/settings-chunks
branch
from
c16ef0f to
23694d5
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Aaaand, it's outdated again --' |
skjnldsv
force-pushed
the
fix/settings-chunks
branch
from
23694d5 to
bdb625b
Compare
Member
|
I guess it doesn't make sense to rebase now. First #22635 should get in and then we rebase this again. |
Member
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/settings-chunks
branch
from
bdb625b to
b8c3ee5
Compare
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
Member
@skjnldsv mind to do this manually? |
Member
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially fix #21024
Avoid files conflict when building and try to fix weird webpack chunk loading issue.