Skip to content

Comments

"Recent status changes" Dashboard#22284

Merged
skjnldsv merged 1 commit intomasterfrom
feature/noid/status_dashboard
Aug 20, 2020
Merged

"Recent status changes" Dashboard#22284
skjnldsv merged 1 commit intomasterfrom
feature/noid/status_dashboard

Conversation

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Aug 18, 2020

Empty content Statuses
0A1E5196-00D4-4C8B-BA11-59062916FC62 7C962DF0-911E-4F10-845E-BB814AB295C9

@georgehrke georgehrke added the 2. developing Work in progress label Aug 18, 2020
@georgehrke georgehrke changed the title Feature/noid/status dashboard "Recent status changes" Dashboard Aug 18, 2020
@georgehrke georgehrke force-pushed the feature/noid/status_dashboard branch from c223bb9 to f8d036f Compare August 18, 2020 13:41
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice! :) Design feedback:

  • The icon should be black, we changed that for Files as well
  • The title is a bit long, let’s cut it to "Recent statuses"?
  • Should we add time info to the subline with a comma? Like "🌴 Vacationing, 3 days ago"

Edited by @georgehrke: Turned into checkboxes

@georgehrke georgehrke force-pushed the feature/noid/status_dashboard branch from 3adb887 to d468b1d Compare August 18, 2020 14:52
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@georgehrke
Copy link
Member Author

@juliushaertl @eneiluj Would you consider the misaligned empty content message an issue in nc/vue-dashboard?
(See original post)

@georgehrke georgehrke force-pushed the feature/noid/status_dashboard branch from fcfbbc1 to 0a34555 Compare August 19, 2020 10:20
@georgehrke
Copy link
Member Author

Rebased and squashed

@georgehrke georgehrke marked this pull request as ready for review August 19, 2020 10:20
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 19, 2020
@georgehrke georgehrke added this to the Nextcloud 20 milestone Aug 19, 2020
@rullzer rullzer mentioned this pull request Aug 20, 2020
@georgehrke georgehrke force-pushed the feature/noid/status_dashboard branch from 1d9a25d to af7ab2d Compare August 20, 2020 11:40
@georgehrke
Copy link
Member Author

Rebased, squashed and fixed @jancborchardt's remark about the dot.

@rullzer
Copy link
Member

rullzer commented Aug 20, 2020

Needs a rebase. But then good to go I think

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the feature/noid/status_dashboard branch from af7ab2d to bd6a6cf Compare August 20, 2020 13:43
@georgehrke
Copy link
Member Author

Rebased again

@faily-bot
Copy link

faily-bot bot commented Aug 20, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32092: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:338
Show full log
  Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
    Given I act as John                                                                   # ActorContext::iActAs()
    And I am logged in as the admin                                                       # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I am logged in                                                                    # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I am logged in as "user1"                                                         # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                                     # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as John                                                                     # ActorContext::iActAs()
    And I set the share with "user0" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    And I see that "user0" can not create in the share                                    # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                    # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "Shared folder"                                       # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                      # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded             # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I set the share with "user1" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    Then I see that "user1" can not create in the share                                   # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I see that "user1" can not be allowed to create in the share                      # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I see that it is not possible to create new files                                 # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Failed asserting that true is false.

@skjnldsv skjnldsv merged commit 0b39e7d into master Aug 20, 2020
@skjnldsv skjnldsv deleted the feature/noid/status_dashboard branch August 20, 2020 15:06
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish feature: status and removed 3. to review Waiting for reviews labels Aug 20, 2020
@jancborchardt
Copy link
Member

@georgehrke @eneiluj not sure if this encoding issue is something for this widget specifically, for user_status or for the Dashboard widget component:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: dashboard feature: status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants