Merged
Conversation
c223bb9 to
f8d036f
Compare
jancborchardt
requested changes
Aug 18, 2020
Member
There was a problem hiding this comment.
Super nice! :) Design feedback:
- The icon should be black, we changed that for Files as well
- The title is a bit long, let’s cut it to "Recent statuses"?
- Should we add time info to the subline with a comma? Like "🌴 Vacationing, 3 days ago"
Edited by @georgehrke: Turned into checkboxes
3adb887 to
d468b1d
Compare
Member
Author
|
@juliushaertl @eneiluj Would you consider the misaligned empty content message an issue in nc/vue-dashboard? |
fcfbbc1 to
0a34555
Compare
Member
Author
|
Rebased and squashed |
rullzer
approved these changes
Aug 19, 2020
Closed
1d9a25d to
af7ab2d
Compare
Member
Author
|
Rebased, squashed and fixed @jancborchardt's remark about the dot. |
Member
|
Needs a rebase. But then good to go I think |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
af7ab2d to
bd6a6cf
Compare
Member
Author
|
Rebased again |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32092: failureacceptance-app-files
Show full logacceptance-app-files-sharing
Show full log |
skjnldsv
approved these changes
Aug 20, 2020
Member
|
@georgehrke @eneiluj not sure if this encoding issue is something for this widget specifically, for user_status or for the Dashboard widget component: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.