Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
object stores are "special" given how they interact with the cache on their own Signed-off-by: Robin Appelman <robin@icewind.nl>
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31219: failuremariadb10.4-php7.3Show full logmysql5.6-php7.2Show full log |
Member
|
This fixes a regression from #21628 |
juliusknorr
approved these changes
Jul 31, 2020
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
Member
|
Not needed - the big was introduced in the above linked pull request which wasn’t backported |
Member
Author
|
there are backports for that, but those aren't merged yet. I'll put this in the original backports instead |
Member
👍 |
solracsf
approved these changes
Aug 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
object stores are "special" given how they interact with the cache on their own
I'm not very happy about adding special cases like this but it's the best I can come up with