Delegate bootstrap registration lazily#21828
Merged
MorrisJobke merged 1 commit intomasterfrom Jul 14, 2020
Merged
Conversation
ChristophWurst
added
enhancement
3. to review
ChristophWurst
commented
Jul 14, 2020
nickvergessen
approved these changes
Jul 14, 2020
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Looks like it could work and do the trick for alternative logins too
2 tasks
* Keep the registration context * Expose the context object for other components * Ensure registration is only run once Search providers are migrated for demonstration. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/lazy-bootstrap-registration-delegation
branch
from
7c2471a to
f03f88b
Compare
Member
|
@ChristophWurst Mind to explain the idea? |
Member
Basically making things even more lazy. |
MorrisJobke
approved these changes
Jul 14, 2020
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code looks good 👍 Nice idea :)
Member
Now I got it :) Thanks 🚀 |
MorrisJobke
added
4. to release
MorrisJobke
deleted the
enhancement/lazy-bootstrap-registration-delegation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search providers are migrated for demonstration.
@rullzer I think that is somewhat the idea you had IIRC. Things like event listeners make little sense to make more lazy because they are quite likely to be used in 90% of our requests, but other stuff if too specific and shouldn't consume too much CPU power not used in most cases, like in #21826.