Do not load app.php if Application implements IBootstrap#21812
Merged
MorrisJobke merged 1 commit intomasterfrom Jul 14, 2020
Merged
Do not load app.php if Application implements IBootstrap#21812MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
cbf0925 to
7d3c308
Compare
Member
Why would it do that? |
Member
Author
Because I moved the |
7d3c308 to
d6339e7
Compare
Member
Author
|
Ready for review :) |
ChristophWurst
approved these changes
Jul 14, 2020
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks great but I'd appreciate a more sane naming of this variable 🤡
skjnldsv
approved these changes
Jul 14, 2020
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
d6339e7 to
d9cc2f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with this is that it changes the load order also for apps without the IBootstrap. Another approach would be a big warning if the app is then one with
IBootstrapbut still has an app.php.#20573 and #20865