Migrate OC_Group post_removeFromGroup hook to actual event object

[MorrisJobke]

Ref #14552

This adds a BeforeUserRemovedEvent to the LDAP backend because it was missing. It's not really before, but we don't have the before state.

Problem with this code:

The setup fails with this exception and I don't really know why:

logs

{
    "reqId": "eHbh95rpFH5mtg7wBVQI",
    "level": 3,
    "time": "2020-07-07T19:31:40+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "--",
    "app": "index",
    "method": "POST",
    "url": "/index.php",
    "message": {
        "Exception": "Error",
        "Message": "Call to a member function getUID() on null",
        "Code": 0,
        "Trace": [
            {
                "file": "/Users/morris/Projects/nextcloud/server/core/Controller/SetupController.php",
                "line": 75,
                "function": "install",
                "class": "OC\\Setup",
                "type": "->",
                "args": [
                    "*** sensitive parameters replaced ***"
                ]
            },
            {
                "file": "/Users/morris/Projects/nextcloud/server/lib/base.php",
                "line": 955,
                "function": "run",
                "class": "OC\\Core\\Controller\\SetupController",
                "type": "->",
                "args": [
                    "*** sensitive parameters replaced ***"
                ]
            },
            {
                "file": "/Users/morris/Projects/nextcloud/server/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/Users/morris/Projects/nextcloud/server/lib/private/Setup.php",
        "Line": 436,
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Safari/605.1.15",
    "version": "20.0.0.0"
}

[juliusknorr]

• Add to Critical changes for developers & admins for Nextcloud 20 #20953 if the old hook is dropped
• Add to Move hooks and emitters all to the eventdispatcher #14552 if there was a fallback added for the old hook that needs to be removed with the removal of hooks

[MorrisJobke]

So #22015 touched also this code. Let me rebase and resolve the code. Should make everything more clean and use then the proper events.

cc @nickvergessen

[nickvergessen]

🦈

Fine by me, although I really loved the before event. Now I see that it can't be triggered all the time, but for the things where it works, its nicer.

[blizzz]

I am not sure why you deprecate BeforeUserRemovedEvent?

[MorrisJobke]

I am not sure why you deprecate BeforeUserRemovedEvent?

Was discussed in #21738 (comment) - as there is no way to guarantee it in all cases it's better to use only the one that reliably fires. And if there is really the need for an before event we can evaluate again on this and check out what is needed there and how to accomplish this.

[blizzz]

I am not sure why you deprecate BeforeUserRemovedEvent?

Was discussed in #21738 (comment) - as there is no way to guarantee it in all cases it's better to use only the one that reliably fires. And if there is really the need for an before event we can evaluate again on this and check out what is needed there and how to accomplish this.

make sense. let's then add info into the PHP doc so that any developer thinking about using it knows what it means, instead of being left puzzled.

[blizzz]

apart of the suggestion to provide brief info on the deprecation into doc block

[MorrisJobke]

apart of the suggestion to provide brief info on the deprecation into doc block

Added.