Conversation
Since this can spam the log quite agressively we should log it as debug and not info. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
blizzz,
kesselb and
nickvergessen
kesselb
approved these changes
Jul 2, 2020
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Fine by me. It was debug for 18.
Member
|
I'm not sure about this. This is getting more important, not less. So I would rather say people have to migrate. For the few things that are still TODO I'm fine if they spam the logs. We should migrate anything that is pending. |
Member
Author
The problem I see with this is if the devs don't care and ignore it. Then end users get spammed with this. And they can't do anything about it. |
Member
|
Fair enough |
ChristophWurst
approved these changes
Jul 2, 2020
nickvergessen
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this can spam the log quite agressively we should log it as debug
and not info.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl