Fix autocomplete for LDAP with shareapi_only_share_with_group_members on#21452
Merged
nickvergessen merged 4 commits intomasterfrom Jun 23, 2020
Merged
Conversation
The problem is that despite it's name IGroup::searchDisplayName() only searches by userid and this is less fixable than changing back to this method here Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ChristophWurst,
icewind1991,
juliusknorr and
rullzer
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
juliusknorr
approved these changes
Jun 23, 2020
ChristophWurst
approved these changes
Jun 23, 2020
nickvergessen
deleted the
bugfix/21451/allow-autocomplete-by-displayname-again
branch
This was referenced Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move back to IGroupManager::displayNamesInGroup()
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here
Fix #21451
Also fixes the broken integration test
sharees_features/sharees.feature:57which is failing since the merge of #16035