Conversation
|
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @Henni and @nickvergessen to be potential reviewers. |
skjnldsv
force-pushed
the
select2-fix
branch
from
1a33985 to
23a8f9c
Compare
core/css/inputs.css
Outdated
There was a problem hiding this comment.
Single quotes in CSS please ;)
core/css/inputs.css
Outdated
There was a problem hiding this comment.
No 0 before the dot please ;)
core/css/inputs.css
Outdated
There was a problem hiding this comment.
Line break after the comma in CSS :)
core/css/inputs.css
Outdated
|
cc @nextcloud/designers also for review and testing! :) |
skjnldsv
force-pushed
the
select2-fix
branch
from
23a8f9c to
2ec7e79
Compare
|
@jancborchardt done :) |
|
nice! btw @skjnldsv you should set yourself as 'public' in our project so you show up on https://nextcloud.com/contributors/ ;-) |
I like working in the darkness of nextcloud. ;) |
|
He, well, you did make it to the nr 2 contributor in the last 7 days according to the nr of commits (yeah, flawed metric, but still) so 'dark' is a big word 👍 but it is, of course, your call, you have only 1 project on your profile page now - https://github.com/skjnldsv - we'd still be proud to show up, too, though 🤐 |
|
I was joking! :) |
|
Awesome, and welcome, you pushed us over 70 contributors!!! https://nextcloud.com/contributors/ |
|
@skjnldsv .select2-searching and .select2-no-results should also have the same padding as .select2-result. Otherwise it is a bit to noisy while searching.
|
|
And to add to @juliushaertl, the background of the »searching« and »No matches found« should be white :) |
|
Here you go :) |
|
@jancborchardt @jospoortvliet @juliushaertl @MariusBluem @nickvergessen |
|
First commit is missing the sign-off Works good and makes the field visible again 👍 |
|
looks good, but please add the missing sign-off @skjnldsv. Thanks! |
|
Doesn't work here in firefox and chrome:
|
MorrisJobke
added
2. developing
|
@MorrisJobke i'm using chromium and ff 50 and it works fine. Please don't remove the review tag every time it doesn't work for you 😆 @nickvergessen @schiessle sign-off added |
skjnldsv
force-pushed
the
select2-fix
branch
from
81b30f7 to
197e964
Compare
|
@MorrisJobke Works for me on ff and chrome. @skjnldsv The padding and background looks good now, but it should also be applied to the searching string:
|
core/css/inputs.css
Outdated
There was a problem hiding this comment.
adding #select2-drop .select2-results .select2-searching should do it. 😉
Current coverage is 57.74% (diff: 100%)@@ master #2133 diff @@
==========================================
Files 1176 1176
Lines 70721 70721
Methods 7213 7213
Messages 0 0
Branches 1211 1211
==========================================
Hits 40837 40837
Misses 29884 29884
Partials 0 0
|
skjnldsv
force-pushed
the
select2-fix
branch
from
197e964 to
65f98d5
Compare
|
@juliushaertl your desire is my command! |
|
@skjnldsv Looks good now. Another rebase to master and ready for review? 😉 |
|
@skjnldsv @juliushaertl any chance to get this done today? It’ll be feature freeze :) |
Fix #1932 + no result fix Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
select2-fix
branch
from
65f98d5 to
c0b376d
Compare
|
@jancborchardt Done! I applied your 3 last commits. |
skjnldsv
added
3. to review
For me this is broken in both -.-
Sure.
I simply don't want broken behaviour - Both browsers run on macOS. On what OS have you tested it? Weird side fact: IE11 and Edge works just fine. But nevertheless - let's merge this - maybe it's a super weird caching issue (even if I cleared it multiple times). 👍 |
|
@MorrisJobke I didn't want to seems presumptuous, sorry if my message felt this way 🤗 Anyway, for the review tag, I was saying this because for a simple fix, I don't think switching back to develop, publishing a single small commit, then reswitching to review is a good idea (maybe i'm wrong 😄) since it only add more useless data to the pr flow 😝 |
|
@skjnldsv thank you and sorry for all the edits I did on the inputs in the meantime ;) |
|
So @LukasReschke also just mentioned this looks a bit broken, and I can confirm: Too much padding, and the width of the input is wrong (due to the calc(100%-14px)): Dropdown overflows to the right: @skjnldsv can you check this out? |
|
Hum, something else must have been added since everything was fine when i was testing this pr! 😕 |
|
@skjnldsv thanks a lot! :) |
9 participants
Fix #1932
@jancborchardt @MariusBluem @nickvergessen