convert text to single line so tabs in translation issue is fixed#2131
Merged
convert text to single line so tabs in translation issue is fixed#2131
Conversation
jancborchardt
added
bug
feature: settings
papercut
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @nickvergessen and @ChristophWurst to be potential reviewers. |
jancborchardt
force-pushed
the
fix-tabs-in-translation
branch
from
0a03508 to
0f9f49a
Compare
67 tasks
Current coverage is 57.79% (diff: 0.00%)@@ master #2131 diff @@
==========================================
Files 1156 1156
Lines 69590 69592 +2
Methods 7004 7004
Messages 0 0
Branches 1204 1204
==========================================
Hits 40224 40224
- Misses 29366 29368 +2
Partials 0 0
|
MorrisJobke
requested changes
Nov 15, 2016
settings/templates/personal.php
Outdated
| ' <a href="https://nextcloud.com/contribute" target="_blank" rel="noreferrer">' . | ||
| $l->t('join development') . '</a>' . $l->t('or') . | ||
| '<a href="https://nextcloud.com/contribute" target="_blank" rel="noreferrer">' . | ||
| $l->t('spread the word') . '</a>' . '!');?> |
Member
There was a problem hiding this comment.
This will not work out with other languages. 😢
Member
There was a problem hiding this comment.
Yeah I was still not sure. But adding HTML to the translation string is asking for trouble.
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
rullzer
force-pushed
the
fix-tabs-in-translation
branch
from
cea79b1 to
317b132
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Member
Author
|
@rullzer @MorrisJobke does the HTML stuff need to be fixed in the firstrunwizard then as well? nextcloud/firstrunwizard@8a6df42 |
Member
|
@jancborchardt yeah would be better |
Member
|
Looks good 👍 |
Member
Author
|
@rullzer can you take care of it since you did it here too? :) |
Member
Author
|
Also review please @MorrisJobke @rullzer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review @MorrisJobke @LukasReschke