Allow to tweak default scopes for accounts#20667
Conversation
tcitworld
added
3. to review
tcitworld
requested review from
ChristophWurst,
juliusknorr,
kesselb and
schiessle
tcitworld
force-pushed
the
tweak-default-scopes-accounts
branch
from
25228f6 to
6e430b3
Compare
tcitworld
force-pushed
the
tweak-default-scopes-accounts
branch
2 times, most recently
from
abca320 to
5da042f
Compare
Close #6582 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
tweak-default-scopes-accounts
branch
from
5da042f to
f4fe762
Compare
| private $config; | ||
|
|
||
| public const DEFAULT_SCOPE_VALUES = [ | ||
| self::PROPERTY_DISPLAYNAME => self::VISIBILITY_CONTACTS_ONLY, |
There was a problem hiding this comment.
We should really make the default on display name and avatar public.
Talk and some other apps are completly unusable at the moment when the settings would be respected.
There was a problem hiding this comment.
Do you want to have the change in this PR or shall I open an issue to discuss instead?
| /** @var IConfig */ | ||
| private $config; | ||
|
|
||
| public const DEFAULT_SCOPE_VALUES = [ |
There was a problem hiding this comment.
| public const DEFAULT_SCOPE_VALUES = [ | |
| public const DEFAULT_SCOPES = [ |
| public const PROPERTY_ADDRESS = 'address'; | ||
| public const PROPERTY_TWITTER = 'twitter'; | ||
|
|
||
| public const PROPERTIES_LIST = [ |
There was a problem hiding this comment.
| public const PROPERTIES_LIST = [ | |
| public const PROPERTIES = [ |
|
Btw the meaning (and labels) were changed in the meantime and they are now not about visibility but whether they are synced to trusted server and the public addressbook/lookup server. So maybe visibility is a wrong constant name nowadays |
This comment has been minimized.
This comment has been minimized.
|
ping @tcitworld |
|
Let's close this for now. We can reopen it later at any time. |
|
My branch though :( |
It can be restored from the github UI at any time :) |
|
Follow-up at #31623 |
8 participants
Closes #6582, Closes #14358, Closes #14959
Lacks proper tests
Needs to be documented afterwards.