Increase max-height on button in welcome email template

[liamjack]

Fixes #13287 implementing @fuanegua's fix proposal (#13287 (comment)) by increasing the max-height of the button to 60px from 40px.

Before:

Short Nextcloud instance name

Long Nextcloud instance name

After

Short Nextcloud instance name

Long Nextcloud instance name

[kesselb]

Would it be possible to have the same size for the install client button?

Thanks for attaching screenshots. That makes reviewing much easier 👍

[liamjack]

I've had a go, but I'm unable to make the "install client" button have the same height as the "go to" button, sorry !

[jancborchardt]

Looks good, thanks a lot for your contribution @liamjack! :)

[jancborchardt]

@liamjack @kesselb @fuanegua could you also review Fix design and layout of notification mails #20380 which is very related? Thanks!

[MorrisJobke]

I pushed a fix to the two missing test cases. This should be fine then.

[MorrisJobke]

Works 👍

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[skjnldsv]

AH, I might have been a little too fast

2) OCA\Settings\Tests\Mailer\NewUserMailHelperTest::testGenerateTemplateWithoutPasswordResetToken
391 | Failed asserting that two strings are equal.
392 | --- Expected
393 | +++ Actual
394 | @@ @@
395 | Install Client: https://nextcloud.com/install/#install-clients\n
396 | \n
397 | \n
398 | ---\n
399 | -TestCloud -\n
400 | +-- \n
401 | +TestCloud - \n
402 | This is an automatically sent email, please do not reply.'
403 |  
404 | /drone/src/apps/settings/tests/Mailer/NewUserMailHelperTest.php:624
405 |  
406 | 3) OCA\Settings\Tests\Mailer\NewUserMailHelperTest::testGenerateTemplateWithoutUserId
407 | Failed asserting that two strings are equal.
408 | --- Expected
409 | +++ Actual
410 | @@ @@
411 | Install Client: https://nextcloud.com/install/#install-clients\n
412 | \n
413 | \n
414 | ---\n
415 | -TestCloud -\n
416 | +-- \n
417 | +TestCloud - \n
418 | This is an automatically sent email, please do not reply.'
419 |  
420 | /drone/src/apps/settings/tests/Mailer/NewUserMailHelperTest.php:848
421 |  

Let's see tests

[rullzer]

Fix for the tests in #20540

[rullzer]

/backport to stable18