Make sure MySQL is not saying 'this' = 'this ' is true#20050
Merged
MorrisJobke merged 1 commit intomasterfrom Apr 15, 2020
Merged
Make sure MySQL is not saying 'this' = 'this ' is true#20050MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
Member
|
Tried testing and to add to the amusement, MySQL 5.7MySQL 8 |
Member
Author
|
Okay, so they fixed it for mysql8 on your machine? Im pretty sure I have 8 too locally and I could reproduce it there |
Member
|
I just tested on
|
Member
Author
|
Okay, seems to be the case for me now too. MariaDB seems to be affected: MariaDB [(none)]> SELECT 'jan' = 'jan ', BINARY 'jan' = 'jan ';
+----------------+-----------------------+
| 'jan' = 'jan ' | BINARY 'jan' = 'jan ' |
+----------------+-----------------------+
| 1 | 0 |
+----------------+-----------------------+
1 row in set (0.00 sec)
MariaDB [(none)]> SELECT VERSION();
+----------------------------------+
| VERSION() |
+----------------------------------+
| 10.1.44-MariaDB-0ubuntu0.18.04.1 |
+----------------------------------+
1 row in set (0.00 sec) |
rullzer
approved these changes
Apr 14, 2020
Member
|
Conflicts :/ |
Member
Let me fix them. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
cdeb084 to
16e9bf2
Compare
Member
|
Basically this made my production instance do boom... I'll have to see why... but for now we can't really release beta3 with this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
100 popcorn, take one and have a look while I perform a magic trick: