Add mindmap type file icon

[ACTom]

No description provided.

[ACTom]

Just add a svg file

[kesselb]

Thanks 👍

Are you the creator of the icon?

[ACTom]

Yes, but I refer to this picture (https://marinettedognanny.com/wp-content/uploads/2018/10/social_icon.png)

[kesselb]

cc @jancborchardt @schiessle

I'm not sure if we are able to use that icon. Mind to have a look for a icon available under MIT license? For example: https://feathericons.com

[ACTom]

@kesselb I used Inkscape to redraw this icon, and now I can confirm that this icon was made by me.

By the way, if I want to add mindmap type in core / js / mimetypelist.js, is it better to submit a new PR, or to submit it directly in this PR?

[kesselb]

Thanks. Please submit another pr for the mime type.

[ACTom]

@kesselb I see that this PR does not have reviewers yet, what do I need to do?

[jancborchardt]

Could look a but more geometric and the lines are a bit thin, but seems fine.

Any particular reason for the choice of color? Ideally color always means something or is related to e.g. a popular product (like red for PDF).

[ACTom]

Any particular reason for the choice of color? Ideally color always means something or is related to e.g. a popular product (like red for PDF).

There is no special reason. This color is chosen because it looks good, and it is different from the colors of other existing formats. You can clearly identify the file type in the list.

[ACTom]

@juliushaertl Waiting for your review.

[kesselb]

@ACTom https://twitter.com/frankdejonge/status/1236727595670134786 :)

It's already queued for 19 and will be reviewed in time.

[ACTom]

@kesselb Oh, I'm sorry, thanks.

[skjnldsv]

Why do we need this icon in server?

[kesselb]

For mindmap files :) Is there a way to add this image as app?

[skjnldsv]

For mindmap files :) Is there a way to add this image as app?

No idea, but can't you not register mimetypes and provide your own img?

[ACTom]

Try: https://git.blink-cf.community/t/update-a-forked-repository-when-the-original-repository-is-updated/1855

(don't forget to backup your work just in case)

Thanks, but where to fix Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithModifiedMimetypelistSignatureData fails? It need to modify https://github.com/nextcloud/server/blob/master/tests/lib/IntegrityCheck/CheckerTest.php .

[ACTom]

@kesselb I have push a new PR to fix Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithModifiedMimetypelistSignatureData fails #23463

[kesselb]

But the test does not fail on master.

1. Rebase this branch and pull the latest changes from master (this repository not your fork)
2. Merge your other patch into this branch

Then we can review in one go and also have a recent CI run.

[ACTom]

But the test does not fail on master.
No, the fail exists on the master and has nothing to do with this PR, you can try it

[kesselb]

I don't see the test failing on a recent CI run: https://drone.nextcloud.com/nextcloud/server/34193

But ignore this for now and rebase this branch to have a recent CI run.

[ACTom]

I don't see the test failing on a recent CI run: https://drone.nextcloud.com/nextcloud/server/34193

But ignore this for now and rebase this branch to have a recent CI run.
@kesselb
I don't know if the link test set you gave is complete, but I pull the master code and execute ./autotest.sh or phpunit --bootstrap tests/bootstrap.php tests/lib/IntegrityCheck/CheckerTest.php then all reported that error, so I opened #23463 to fix it.

[kesselb]

Please rebase this branch to have a recent CI run.

[ACTom]

@ChristophWurst @rullzer Can you review it?

[szaimen]

Ping @rullzer

[ChristophWurst]

Fine by me

[szaimen]

🎉

[nursoda]

Wait, there's a patch for NC 19 and 21 but not for 20? Or did I overlook something?

[kesselb]

21

[skjnldsv]

/backport to stable20