Add option to check share ACL's when listing directories#19399
Merged
Add option to check share ACL's when listing directories#19399
Conversation
icewind1991
added
2. developing
|
icewind1991
force-pushed
the
smb-read-acl
branch
from
097ff56 to
8281544
Compare
icewind1991
changed the title
icewind1991
added
3. to review
icewind1991
force-pushed
the
smb-read-acl
branch
from
8281544 to
990fd70
Compare
skjnldsv
reviewed
Apr 10, 2020
icewind1991
force-pushed
the
smb-read-acl
branch
from
990fd70 to
cc80e8a
Compare
icewind1991
force-pushed
the
smb-read-acl
branch
from
cc80e8a to
9923f41
Compare
Member
Author
|
rebased, unit tests are happy |
If a file or folder in a directory doesn't have read permissions they will not be shown Note that enabling this option incurs a performance penalty additional requests need to be made to get all the acl. Additionally the acl resolving logic is fairly primitive at the moment and might not work correctly in all setups (it should error to showing the entry) Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
smb-read-acl
branch
from
9923f41 to
65118cf
Compare
Member
|
Failing php-cs check 😉 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
smb-read-acl
branch
from
65118cf to
7f32fe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman robin@icewind.nl