Handle long dav property paths by hashing them#19242
Merged
Conversation
georgehrke
requested changes
Jan 31, 2020
Member
georgehrke
left a comment
georgehrke
left a comment
There was a problem hiding this comment.
This breaks custom properties for CalDAV (and probably CardDAV as well) for me:
To reproduce, just open the calendar app and click a calendar to hide it. When reloading, it should still be hidden, but it's not.
Member
|
Neither Calendar nor AddressBook are extending Node |
Member
Author
|
switched to |
Member
Author
|
nevermind |
Member
Author
georgehrke
approved these changes
Feb 17, 2020
Signed-off-by: Robin Appelman <robin@icewind.nl>
test behaviour not implementation Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
force-pushed
the
dav-long-properties
branch
2 times, most recently
from
5a40940 to
e44c276
Compare
Member
Author
|
/backport to stable18 |
Member
Author
|
/backport to stable17 |
|
The backport to stable17 failed. Please do this backport manually. |
|
backport to stable18 in #20030 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to extending the column (#18126).
Even ignoring the migration problems with extending the problem, we then run into issues where we can't have an index on long string columns, which would require adding a separate
path_hashcolumn to query on.Since we don't actually ever query the path from the table and only use it for searching, simply storing only the hash works just fine.
PR includes