Skip to content

Center Buttons#19238

Merged
skjnldsv merged 2 commits intonextcloud:masterfrom
MarcMichalsky:patch-1
Feb 3, 2020
Merged

Center Buttons#19238
skjnldsv merged 2 commits intonextcloud:masterfrom
MarcMichalsky:patch-1

Conversation

@MarcMichalsky
Copy link
Contributor

@MarcMichalsky MarcMichalsky commented Jan 31, 2020

Since Version 18.0.0 the Registration button of the registration app is not centered anymore.

@MarcMichalsky
Center Buttons
9f473f7 
Since Version 18.0.0 the Registration button of the [registration app](https://github.com/pellaeon/registration) is not centered anymore.
@georgehrke
Copy link
Member

georgehrke commented Jan 31, 2020

@MarcMichalsky Can you please provide before / after screenshots? Thx

Did you test whether your change affects other alternative logins?

@georgehrke georgehrke added the 3. to review Waiting for reviews label Jan 31, 2020
@kesselb
Copy link
Contributor

kesselb commented Jan 31, 2020

Should fix #19049

@kesselb kesselb mentioned this pull request Jan 31, 2020
Closed
Dennis1993
Dennis1993 approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@Dennis1993 Dennis1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me on NC 18.0.0 on desktop and mobile!

MarcMichalsky
MarcMichalsky commented Jan 31, 2020
View reviewed changes
Copy link
Contributor Author

@MarcMichalsky MarcMichalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the changes on my site. It works well and I didn't spot any disturbance with other buttons.

before
after

@kesselb kesselb added the bug label Feb 1, 2020
@kesselb kesselb added this to the Nextcloud 19 milestone Feb 1, 2020
skjnldsv
skjnldsv approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and make sense

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 3, 2020
@skjnldsv skjnldsv merged commit 4c9cc5f into nextcloud:master Feb 3, 2020
@welcome
Copy link

welcome bot commented Feb 3, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@skjnldsv
Copy link
Member

skjnldsv commented Feb 3, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 3, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 3, 2020

backport to stable18 in #19271

@MarcMichalsky MarcMichalsky deleted the patch-1 branch February 3, 2020 09:27
This was referenced Feb 4, 2020
Closed
Closed
@hensephil
Copy link

hensephil commented Feb 4, 2020

Can you please show me the whole css config. Because it doesn't work for me.

This was referenced Feb 7, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dennis1993 Dennis1993 Dennis1993 approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

7 participants

@MarcMichalsky @georgehrke @kesselb @skjnldsv @hensephil @Dennis1993 @juliusknorr