Improve Opcache detection#19191
Merged
rullzer merged 1 commit intonextcloud:masterfrom Apr 15, 2020
laurisb:patch-1
Merged
Conversation
Improve Opcache detection by checking if extension is loaded, as opcache_get_status() is commonly disabled on shared hosting servers
Contributor
|
Thanks 👍 |
kesselb
approved these changes
Jan 29, 2020
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
php -r "var_dump(extension_loaded('Zend OPcache'));"
bool(true)
php -r "var_dump(function_exists('opcache_get_status'));"
bool(true)
php -d disable_functions=opcache_get_status -r "var_dump(extension_loaded('Zend OPcache'));"
bool(true)
php -d disable_functions=opcache_get_status -r "var_dump(function_exists('opcache_get_status'));"
bool(false)
ChristophWurst
approved these changes
Apr 15, 2020
Member
|
Tested and works! |
ChristophWurst
added
4. to release
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Opcache detection by checking if extension is loaded, as opcache_get_status() is commonly disabled on shared hosting servers