Added functions to check etag of elements - integration tests#1887
Added functions to check etag of elements - integration tests#1887MorrisJobke merged 5 commits intomasterfrom
Conversation
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @rullzer and @PVince81 to be potential reviewers. |
|
Mmmm the test fails. |
rullzer
force-pushed
the
downstream-26370
branch
from
b9b7a62 to
9933803
Compare
| } | ||
|
|
||
| if (!$this->canAccessShare($share, false)) { | ||
| if (!$this->canAccessShare($share, true)) { |
There was a problem hiding this comment.
Well true is the default. Also the parameter was specifically introduced for this case: #637
There was a problem hiding this comment.
Yeah I remember that. It is just that apparently a lot of tests still reply on you to be able to delete received shares via the API.
|
Regarding the last commit, shouldn't you delete the "share exception" instead of the group share, to unshare from self?
|
|
@nickvergessen ah yes could do that. lets first see if this fixes it then I'll try to make it a bit more beautiful :D |
rullzer
force-pushed
the
downstream-26370
branch
3 times, most recently
from
de9e20d to
a8782c4
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
downstream-26370
branch
from
a8782c4 to
ea786a3
Compare
|
@nickvergessen could you smash? Then this is ready to get in |
|
Smashing passed. 👍 |
|
👍from me as well |
5 participants
cc @rullzer @nickvergessen