Combine exact and other matches for transfer ownership#18757
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/transfer-ownership-autocomplete-matching
branch
from
d077135 to
78ee689
Compare
ChristophWurst
added
3. to review
ChristophWurst
requested review from
georgehrke,
juliusknorr,
rullzer and
skjnldsv
rullzer
approved these changes
Jan 8, 2020
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
O jikes... good catch.
somehow this feels as something we should probably abstract away in a package somewhere ;)
Member
|
master is NC19 now. |
skjnldsv
approved these changes
Jan 9, 2020
Contributor
|
/backport to stable18 |
wiswedel
approved these changes
Jan 9, 2020
ChristophWurst
added
4. to release
|
backport to stable18 in #18769 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18624.
Before: only suggestions for partial matches. Exact matches don't work.
After: both work 🚀